doc(test): add missing passed and error on TextContext
#59322
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
SimonSchick
changed the title
passed and error on TextContext
SimonSchick
changed the title
passed and error on TextContextpassed and error on TextContext
SimonSchick
force-pushed
the
docs/missing-test-context-properties
branch
from
485f8ca to
24c4abc
Compare
SimonSchick
force-pushed
the
docs/missing-test-context-properties
branch
from
24c4abc to
7ddb4dc
Compare
…rties on TextContext
| added: v20.12.0 | ||
| --> | ||
|
|
||
| Indicates whether the test succeeded, this defaults to `true` before the test is executed, e.g. in a `beforeEach` hook. |
There was a problem hiding this comment.
Do you happen to know where this is set? The implementation you cited does not do this, and that behaviour seems wrong. I would expect context.passed to be nullish until there is something to report.
Comment on lines
+3624
to
+3625
| The failure reason for this test, if a non `Error` object was thrown it will be wrapped and available via the `cause` | ||
| property. |
There was a problem hiding this comment.
Suggested change
| The failure reason for this test, if a non `Error` object was thrown it will be wrapped and available via the `cause` | |
| property. | |
| The failure reason for the test/case; if anything other than an instance of `Error` was thrown, that will be wrapped and available via `context.error.cause`. |
(line length may anger the linter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59321 and #51485 for implementation