Skip to content

Starting items/questions #1

@andyfaff

Description

@andyfaff

For discussion:

  • a gitattributes to set all line endings to LF
  • a GH workflow to use black from the get-go to enforce python style.
  • clarify whether the workflow_flow dispatch item allows you to choose where code is uploaded to (the option)
  • at the moment the wheel build is fail-fast:false. ATM I think this means that one of the wheel matrix entries can fail, but if it's in a PyPI release run then the ones that did succeed will upload, meaning that we're missing one or more wheels. I think it would be better to have fail-fast:true?
  • when we want to make a release presumably there's already been a branch made. At release time is a commit is made to set SOURCE_REF_TO_BUILD to the tag name on the release branch?
  • Can we have another input question on workflow_dispatch to ask for the branch/tag name to build? i.e. instead of having to set SOURCE_REF_TO_BUILD in a commit. That branch/tag is then checked out.
  • I'm not sure that all the wheels are uploaded in one batch. Consider putting all wheels in one location. e.g:
# in the wheel build entry
-uses: actions/upload-artifact
 with:
   name: wheels-${{ matrix.python }}-${{ matrix.buildplat[1] }}-${{ matrix.buildplat[2] }}
   path: ./dist/*.whl   # location of where the wheels are built
 
# in upload entry. this step followed by PyPI upload.
- uses: actions/download-artifact
  with:
    pattern: wheels-*
    merge-multiple: true     #  downloads the entire set
    path: dist
  • the upload to PyPI action should check that you've just built a tag before it makes a release.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions