Fix #1238 by enhancing HandoffInputData and enable passing async functions #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
commented
Jul 30, 2025
| @@ -785,6 +786,8 @@ async def execute_handoffs( | |||
| ) | |||
| raise UserError(f"Invalid input filter: {input_filter}") | |||
| filtered = input_filter(handoff_input_data) | |||
| if inspect.isawaitable(filtered): | |||
There was a problem hiding this comment.
to support this use case: #1238 (comment)
| Note that, since this property was added later on, it's optional for backwards compatibility. | ||
| """ | ||
|
|
||
| def clone(self, **kwargs: Any) -> HandoffInputData: |
There was a problem hiding this comment.
added clone method for convenience but if we don't want to have this, happy to revert this change
| @@ -262,7 +263,7 @@ async def test_handoff_filters(): | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
| async def test_async_input_filter_fails(): | |||
| async def test_async_input_filter_supported(): | |||
There was a problem hiding this comment.
if we didn't intentionally block async functions, i believe changing this is a good addition
| @@ -241,6 +241,7 @@ def remove_new_items(handoff_input_data: HandoffInputData) -> HandoffInputData: | |||
| input_history=handoff_input_data.input_history, | |||
| pre_handoff_items=(), | |||
| new_items=(), | |||
| run_context=handoff_input_data.run_context, | |||
There was a problem hiding this comment.
I added run_context param in tests but the ones under examples do not have the param. this means backward compatibility is kept
| @@ -49,8 +49,24 @@ class HandoffInputData: | |||
| handoff and the tool output message representing the response from the handoff output. | |||
| """ | |||
|
|
|||
| run_context: RunContextWrapper[Any] | None = None | |||
There was a problem hiding this comment.
if a different name is preferred, happy to rename this
seratch
added a commit
to openai/openai-agents-js
that referenced
this pull request
Jul 30, 2025
rm-openai
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1238