Skip to content

[GR-67327] Add missing check for negative value to int.__lshift__ #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

[GR-67327] Add missing check for negative value to int.__lshift__ #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions graalpython/com.oracle.graal.python.test/src/tests/test_int.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,37 @@ def test_bigint():
assert isinstance(i, int)
assert i == BIG_NUMBER

def test_bigint_lshift():
INT_SHIFT = -2147483648
LONG_SHIFT = -2147483649

assert_raises(ValueError, lambda: 0 << INT_SHIFT)
assert_raises(ValueError, lambda: -1 << INT_SHIFT)
assert_raises(ValueError, lambda: ((1 << 32) - 1) << INT_SHIFT)
assert_raises(ValueError, lambda: ((1 << 64) - 1) << INT_SHIFT)
assert_raises(ValueError, lambda: BIG_NUMBER << INT_SHIFT)

assert_raises(ValueError, lambda: 0 << LONG_SHIFT)
assert_raises(ValueError, lambda: -1 << LONG_SHIFT)
assert_raises(ValueError, lambda: 2147483647 << LONG_SHIFT)
assert_raises(ValueError, lambda: 9223372036854775807 << LONG_SHIFT)
assert_raises(ValueError, lambda: BIG_NUMBER << LONG_SHIFT)

def test_bigint_rshift():
INT_SHIFT = -2147483648
LONG_SHIFT = -2147483649

assert_raises(ValueError, lambda: 0 >> INT_SHIFT)
assert_raises(ValueError, lambda: -1 >> INT_SHIFT)
assert_raises(ValueError, lambda: ((1 >> 32) - 1) >> INT_SHIFT)
assert_raises(ValueError, lambda: ((1 >> 64) - 1) >> INT_SHIFT)
assert_raises(ValueError, lambda: BIG_NUMBER >> INT_SHIFT)

assert_raises(ValueError, lambda: 0 >> LONG_SHIFT)
assert_raises(ValueError, lambda: -1 >> LONG_SHIFT)
assert_raises(ValueError, lambda: 2147483647 >> LONG_SHIFT)
assert_raises(ValueError, lambda: 9223372036854775807 >> LONG_SHIFT)
assert_raises(ValueError, lambda: BIG_NUMBER >> LONG_SHIFT)

def test_boolean2int():
assert int(True) == 1
Expand Down Expand Up @@ -425,10 +456,10 @@ def test_create_int_from_float():
assert True
else:
assert False, "expected ValueError"

class FloatSub(float):
pass

try:
int(FloatSub(float('nan')))
except ValueError:
Expand Down
3 changes: 2 additions & 1 deletion ...om.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntBuiltins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1852,9 +1852,10 @@ static PInt doGuardedBiI(Node inliningTarget, BigInteger left, int right, PRaise
static PInt doPiL(PInt left, long right,
@Bind("this") Node inliningTarget,
@Shared @Cached PRaiseNode raiseNode) {
raiseNegativeShiftCount(inliningTarget, right < 0, raiseNode);
int rightI = (int) right;
if (rightI == right) {
return doPiI(left, rightI, inliningTarget, raiseNode);
return doGuardedBiI(inliningTarget, left.getValue(), rightI, raiseNode);
} else {
throw raiseNode.raise(inliningTarget, PythonErrorType.OverflowError);
}
Expand Down