BUG: Avoid copying categorical codes if copy=False
#62000
Merged
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 30, 2025
| @@ -575,7 +575,7 @@ def astype(self, dtype: AstypeArg, copy: bool = True) -> ArrayLike: | |||
| # GH 10696/18593/18630 | |||
| dtype = self.dtype.update_dtype(dtype) | |||
| self = self.copy() if copy else self | |||
There was a problem hiding this comment.
Do we need this line if we pass self._set_dtype(dtype, copy=copy)?
There was a problem hiding this comment.
I wasn't entirely sure. The self.copy is also creating a new Categorical object which is desired, I assume.
fjetter
changed the title
copy=False
mroeschke
reviewed
Jul 31, 2025
mroeschke
approved these changes
Aug 1, 2025
|
Thanks @fjetter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Categorical codes are always copied by
recode_for_categoriesregardless of the copy argument. This fixes it by passing the copy argument down torecode_for_categories[ ] closes #xxxx (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.