Skip to content

BUG: Fix assert_series_equal with check_category_order=False for categoricals with nulls #62017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −2
Open

BUG: Fix assert_series_equal with check_category_order=False for categoricals with nulls #62017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98888c7
BUG: Fix assert_series_equal with check_category_order=False for cate…
anishkarki Aug 1, 2025
6358565
BUG: added a line in doc/source/whatsnew/v3.0.0.0.rst
anishkarki Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,6 +938,7 @@ Other
- Bug in :meth:`Series.replace` and :meth:`DataFrame.replace` inconsistently replacing matching instances when ``regex=True`` and missing values are present. (:issue:`56599`)
- Bug in :meth:`Series.replace` and :meth:`DataFrame.replace` throwing ``ValueError`` when ``regex=True`` and all NA values. (:issue:`60688`)
- Bug in :meth:`Series.to_string` when series contains complex floats with exponents (:issue:`60405`)
- Bug in :meth:`pandas.testing.assert_series_equal` incorrectly failing when comparing :class:`Categorical` series with null values and different category orders when ``check_category_order=False`` (:issue:`62008`)
- Bug in :meth:`read_csv` where chained fsspec TAR file and ``compression="infer"`` fails with ``tarfile.ReadError`` (:issue:`60028`)
- Bug in Dataframe Interchange Protocol implementation was returning incorrect results for data buffers' associated dtype, for string and datetime columns (:issue:`54781`)
- Bug in ``Series.list`` methods not preserving the original :class:`Index`. (:issue:`58425`)
Expand Down
4 changes: 2 additions & 2 deletions pandas/_testing/asserters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,8 @@ def assert_categorical_equal(
lc, rc = left.categories, right.categories
assert_index_equal(lc, rc, obj=f"{obj}.categories", exact=exact)
assert_index_equal(
left.categories.take(left.codes),
right.categories.take(right.codes),
left.categories.take(left.codes, allow_fill=True, fill_value=np.nan),
right.categories.take(right.codes, allow_fill=True, fill_value=np.nan),
obj=f"{obj}.values",
exact=exact,
)
Expand Down
16 changes: 16 additions & 0 deletions pandas/tests/util/test_assert_series_equal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,3 +507,19 @@ def test_assert_series_equal_check_exact_index_default(left_idx, right_idx):
ser2 = Series(np.zeros(6, dtype=int), right_idx)
tm.assert_series_equal(ser1, ser2)
tm.assert_frame_equal(ser1.to_frame(), ser2.to_frame())


def test_assert_series_equal_categorical_nulls_different_order():
# https://github.com/pandas-dev/pandas/issues/62008
values = ["B", np.nan, "D"]
categorical_left = ["B", "D"]
categorical_right = categorical_left[::-1] # Different Order

left = Series(Categorical(values, categories=categorical_left))
right = Series(Categorical(values, categories=categorical_right))

tm.assert_series_equal(left, right, check_category_order=False)

msg = "Categorical.categories are different"
with pytest.raises(AssertionError, match=msg):
tm.assert_series_equal(left, right, check_category_order=True)
Loading