Skip to content

[RFC] FILTER_THROW_ON_FAILURE #18896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[RFC] FILTER_THROW_ON_FAILURE #18896

wants to merge 3 commits into from

Conversation

DanielEScherzer
Copy link
Member

@DanielEScherzer DanielEScherzer commented Jun 21, 2025 •
edited
Loading

@DanielEScherzer DanielEScherzer linked an issue Jun 21, 2025 that may be closed by this pull request
FILTER_THROW_ON_FAILURE flag? #16710
Open
@DanielEScherzer DanielEScherzer changed the title [RFC} FILTER_THROW_ON_FAILURE [RFC] FILTER_THROW_ON_FAILURE Jun 21, 2025
@DanielEScherzer DanielEScherzer marked this pull request as draft June 22, 2025 00:21
@DanielEScherzer DanielEScherzer force-pushed the filter-throw-on-failure branch from 8c5abca to 86969e5 Compare June 22, 2025 05:52
divinity76
divinity76 reviewed Jun 22, 2025
View reviewed changes
@DanielEScherzer DanielEScherzer force-pushed the filter-throw-on-failure branch from 86969e5 to 10dab9e Compare July 5, 2025 23:17
divinity76
divinity76 reviewed Jul 6, 2025
View reviewed changes
@divinity76
Copy link
Contributor

LGTM fwiw. (I don't have access use the actual github review form on php-src, but it lgtm.)

derickr
derickr reviewed Jul 14, 2025
View reviewed changes
@DanielEScherzer DanielEScherzer force-pushed the filter-throw-on-failure branch from 5e658f7 to e16eb44 Compare July 14, 2025 23:42
DanielEScherzer referenced this pull request Jul 15, 2025
@DanielEScherzer
Arginfo: add and use known strings for attribute values
142e378
@DanielEScherzer DanielEScherzer force-pushed the filter-throw-on-failure branch from e16eb44 to af6b103 Compare August 20, 2025 09:09
@DanielEScherzer
Copy link
Member Author

Rebased for conflict from #19073

@DanielEScherzer DanielEScherzer marked this pull request as ready for review August 20, 2025 09:09
iluuu1994
iluuu1994 reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should have at least a simple successful test using FILTER_THROW_ON_FAILURE.

@DanielEScherzer
Copy link
Member Author

Seems like we should have at least a simple successful test using FILTER_THROW_ON_FAILURE.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@derickr derickr Awaiting requested review from derickr

+1 more reviewer

@divinity76 divinity76 divinity76 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ABI break Extension: filter RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FILTER_THROW_ON_FAILURE flag?
4 participants
@DanielEScherzer @divinity76 @derickr @iluuu1994