Poison VM stack #19334
Open
Poison VM stack #19334
+121
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ASAN/MSAN interfaces to poison new VM stack pages and poped frames. This is useful because without this instrumentation, ASAN considers memory regions past the current frame as addressable (since we allocate one page at a time), and MSAN considers them initialized if they have been used by other function calls before.
I extracted this from the partials implementation, for which it has been useful to spot issues. This was before #18858 was published, but I still took a little bit of inspiration from it while extracting this PR.