Fix GH-17068: Add pack()/unpack() format for signed integer endianness #19368
+524
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
pack-endianness
branch
from
28d0948 to
bc83418
Compare
NattyNarwhal
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17068
Adds signed integer endianness support to pack()/unpack() functions. There are 2 new format codes (from the original issue): m/y for signed 2-byte (little/big endian), M/Y for signed 4-byte (little/big endian), and p/j for signed 8-byte (little/big endian). It follows the existing pattern where lowercase matches uppercase endianness.
I also moved pack tests in a dedicated folder.