#202 Add rule to prevent final constructors in doctrine entities #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing checks don't seem to be related to the changes of this PR. |
ondrejmirtes
requested changes
Dec 15, 2022
| throw new ShouldNotHappenException(); | ||
| } | ||
|
|
||
| return [sprintf( |
There was a problem hiding this comment.
Please use RuleErrorBuilder here.
| return []; | ||
| } | ||
|
|
||
| $classReflection = $scope->getClassReflection(); |
There was a problem hiding this comment.
You're reporting in all classes, not just entities.
There was a problem hiding this comment.
If I'm correct, this should work now only for entities. I've taken this code from EntityNotFinalRule for the detection, if the class is an entity
if ($this->objectMetadataResolver->isTransient($classReflection->getName())) {
return [];
}
$metadata = $this->objectMetadataResolver->getClassMetadata($classReflection->getName());
if ($metadata !== null && $metadata->isEmbeddedClass === true) {
return [];
}
|
Hi, sorry for the delay :) |
ondrejmirtes
requested changes
Feb 17, 2023
rules.neon
Outdated
| @@ -23,10 +23,13 @@ rules: | |||
| - PHPStan\Rules\Doctrine\ORM\DqlRule | |||
| - PHPStan\Rules\Doctrine\ORM\RepositoryMethodCallRule | |||
| - PHPStan\Rules\Doctrine\ORM\EntityNotFinalRule | |||
| - PHPStan\Rules\Doctrine\ORM\EntityConstructorNotFinalRule | |||
There was a problem hiding this comment.
You need to remove it from the rules section.
There was a problem hiding this comment.
Ah, okay. I removed it there. :)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #202.
What do you think about that?