Skip to content

Add Chart.Residual – Modified Lollipop Chart Implementation #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

LibraChris
Copy link

Description:

This PR adds Chart.Residual, a customized variant of the Lollipop chart (see #417) tailored for showcasing deviation of values to a reference values.

Key updates:

  • Add Chart.Residual to ChartAPI/Chart2D
  • Add Basic documentation and usage examples under DISTRIBUTION CHARTS.

Copy link
Collaborator

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but please do not set any defaults for legend grouping, see comments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to just "residual.fsx", as the path will then be /distribution-charts/residual.html on the hosted docs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, add it to the 04_distribution-charts solution folder

|> GenericChart.mapTrace (
Trace2DStyle.Scatter(
LegendGroup = (defaultArg GroupName "Datapoints"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify from comment above, just pass ?LegendGroup = GroupName, so the userchoice is respected, but no default is set. Same for any other legend group settings.

?Name: string,
?ReferenceName: string,
?GroupName: string,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think grouping the legend items here is unnecessary, as we will have one trace per group per default, and also same name for reference line and group:

grafik

please refactor so that, if no group names are set by the user, no trace grouping is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants