Skip to content

Fix dnsmasq install using interactive mode and failing codeflare CI #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kryanbeane
Copy link
Contributor

Issue link

N/A

What changes have been made

Added -y to the apt-get install for dnsmasq to fix failing CI

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested a review from dimakis August 1, 2025 10:42
@chipspeak
Copy link

Cheers for hopping on this @kryanbeane

@chipspeak
Copy link

/approve

@laurafitzgerald
Copy link

/approve
/lgtm

Copy link

openshift-ci bot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chipspeak, kryanbeane, laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chipspeak,kryanbeane,laurafitzgerald]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 1, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cac2607 into project-codeflare:main Aug 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants