Implement static shape inference for AdvancedSubtensor #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
advanced_subtensor_static_shape
branch
from
2c8d202 to
a0fb9d9
Compare
ricardoV94
force-pushed
the
advanced_subtensor_static_shape
branch
from
a0fb9d9 to
5a12f3f
Compare
|
Failing jax test is unrelated: #1567 |
lucianopaz
approved these changes
Aug 1, 2025
| assert y[bool_idx1].type.shape == (None, 5, 6) | ||
| assert y[bool_idx1, :, None:-4:-1].type.shape == (None, 5, 3) | ||
| assert y[bool_idx1, idx2].type.shape == (3, None, 6) | ||
| assert y[bool_idx1, idx1, :].type.shape == (4, 6) |
There was a problem hiding this comment.
Does this raise a runtime error if the number of true entries in bool_idx1 != 4
There was a problem hiding this comment.
Yes, there's no way indexing can happen otherwise. If idx1 was being broadcast we may at some point optimize away the broacast (with "shape_unsafe" tag, see #1561), but we don't do that yet.
| ] | ||
| else: | ||
| # This could have been a basic subtensor! | ||
| indexed_shape = basic_group_shape |
There was a problem hiding this comment.
It has no vector indices, Subtensor handles all those cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1532
Closes #1565
Logic could be slightly simplified after #1564
📚 Documentation preview 📚: https://pytensor--1566.org.readthedocs.build/en/1566/