-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
Closed
Labels
3.10only security fixesonly security fixes3.11only security fixesonly security fixes3.12only security fixesonly security fixestopic-SSLtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
The test case test_get_ciphers
assumes that SSLContext.set_ciphers('AESGCM')
adds the cipher suites AES256-GCM-SHA384
and AES128-GCM-SHA256
. These are OpenSSL's names for AES-GCM with RSA key exchange and RSA authentication:
AES256-GCM-SHA384 TLSv1.2 Kx=RSA Au=RSA Enc=AESGCM(256) Mac=AEAD
AES128-GCM-SHA256 TLSv1.2 Kx=RSA Au=RSA Enc=AESGCM(128) Mac=AEAD
These are old, problematic ciphers suites that do not provide perfect forward secrecy. The ciphers are blocked by some crypto policies, e.g. FIPS 140-3. We should relax the tests a bit and check for variants with FFDH or ECDH key exchange, e.g. ECDHE-ECDSA-AES256-GCM-SHA384
, ECDHE-RSA-AES256-GCM-SHA384
, or DHE-RSA-AES256-GCM-SHA384
.
Metadata
Metadata
Assignees
Labels
3.10only security fixesonly security fixes3.11only security fixesonly security fixes3.12only security fixesonly security fixestopic-SSLtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error