Skip to content

Ignore ./rails #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2012
Merged

Ignore ./rails #3

merged 1 commit into from
Aug 17, 2012

Conversation

simonjefford
Copy link
Contributor

This allows users to have a clone in their rails-dev-box checkout that will automatically appear in their /vagrant folder. That way they can edit files "locally" and test the changes on the vagrant box.

This allows users to have a clone in their rails-dev-box checkout that
will automatically appear in their /vagrant folder.
@fxn
Copy link
Member

fxn commented Aug 17, 2012

This PR comes in the right time. I am pondering changing the "What's next section" to suggest cloning the fork in the home of the box as you do, since git and SSH keys and preferred editor are all set in the host normally. Is it working well for you?

Nevertheless, what is the point of ignoring the "rails" directory? People are not going yo modify the virtual machine itself right?

@simonjefford
Copy link
Contributor Author

I guess it's just an OCD thing, my command prompt no longer shows a dirty working folder if "rails" is ignored :-) Also, slightly more seriously, I guess if you are going to contribute a change to rails-dev-box itself this would prevent accidentally adding rails as a submodule.

Agree it's probably of marginal benefit though...

(Either way, adding something to the README to suggest doing this is probably a good idea)

@fxn
Copy link
Member

fxn commented Aug 17, 2012

On a second thought, that may helpful to me myself also to check how editing from /vagrant works... in then. Thanks!

fxn added a commit that referenced this pull request Aug 17, 2012
@fxn fxn merged commit fab86b3 into rails:master Aug 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants