Change JS Object map to use reduce #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel the we will use the python dict comprehension one liner the equivalent JS one liner should be used as well
for matching performance we could use the more verbose but still true to the expression of mapping example bellow
```j
const newDict = Object.entries(originalDict).reduce(newDict, ([key, value]) => {
newDict[key] = value * value
return newDict
}), {})
```
in this solution I just used JS's destruct and variable key dictionary
in the proposed PR I used the combination of arrow function default return and object spread to make it a one liner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel that if we use the python dict comprehension one liner the equivalent JS one liner should be used as well
for better performance we could use the more verbose but still true to the expression of mapping example bellow
in this solution I just used JS's destruct and variable key dictionary
in the proposed PR I used the combination of arrow function default return and object spread to make it a one liner