Skip to content

Update build dependency jgit to 7.3.0.202506031305-r #23109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

natsukagami
Copy link
Contributor

@natsukagami natsukagami commented May 6, 2025

Notably it adds support for recognizing git worktrees.
Trying to compile the compiler would fail under a worktree on the old version, due to jgit not recognizing
it as a repository.

Old version is over 7 years old at this point.

@natsukagami natsukagami marked this pull request as draft May 6, 2025 12:26
@natsukagami
Copy link
Contributor Author

Too new for java 8. Unfortunately only versions >= 7.0.0 has worktree support.

@natsukagami natsukagami changed the title Update build dependency jgit to 7.2.0.202503040940-r Update build dependency jgit to 7.3.0.202506031305-r Jul 31, 2025
Notably it adds support for recognizing [git worktrees](https://www.tomups.com/posts/git-worktrees/).
Trying to compile the compiler would fail under a worktree on the old version, due to jgit not recognizing
it as a repository.

Old version is over 7 years old at this point.
@natsukagami natsukagami marked this pull request as ready for review August 4, 2025 09:42
@natsukagami natsukagami requested a review from hamzaremmal August 4, 2025 09:43
@hamzaremmal
Copy link
Member

Too new for java 8. Unfortunately only versions >= 7.0.0 has worktree support.

We will be moving to 17 soon. I guess you can rebase when the changes are merged.

@natsukagami
Copy link
Contributor Author

The failing Scala.js test seems interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants