-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Labels
P0Priority: CriticalPriority: CriticalbugSomething isn't workingSomething isn't workingcrashIssues involving a crashIssues involving a crashgood first issueGood for newcomersGood for newcomers
Description
There's a static initialization order fiasco in the implementation of the days since 2000 block (https://en.cppreference.com/w/cpp/language/siof).
SensingBlocks::clock
(see src/blocks/sensingblocks.cpp
) depends on the Clock
singleton (Clock::instance()
) which is initialized after SensingBlocks::clock
.
Sensing blocks must hold a pointer to a Clock object for testing (mocking) reasons. It should point to Clock::instance()
by default.
Metadata
Metadata
Assignees
Labels
P0Priority: CriticalPriority: CriticalbugSomething isn't workingSomething isn't workingcrashIssues involving a crashIssues involving a crashgood first issueGood for newcomersGood for newcomers