Inline the custom JavaScript using wp_print_inline_script_tag() #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated version number in additional-javascript.php, package.json, and package-lock.json to 1.1.6. - Modified readme.txt to reflect the new stable tag of 1.1.6. - Added changelog entries for version 1.1.6: - Inline the custom JavaScript using `wp_print_inline_script_tag()`. - Ensure the script is printed in the footer.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Additional JavaScript plugin to version 1.1.6, modernizing how custom JavaScript is output in WordPress sites by adopting WordPress best practices and improving performance.
- Replaces manual inline script output with the WordPress-recommended
wp_print_inline_script_tag()function - Moves JavaScript output from page header to footer for better performance
- Updates version numbers and documentation across all relevant files
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| additional-javascript.php | Updated version number, moved script hook from wp_head to wp_footer, and replaced manual script tag generation with wp_print_inline_script_tag() |
| package.json | Bumped version from 1.1.5 to 1.1.6 |
| readme.txt | Updated stable tag and added changelog entry for version 1.1.6 |
| CHANGELOG.md | Added changelog entry documenting the JavaScript output improvements |
| ## [1.1.6] - 2025-08-11 | ||
|
|
||
| ### Fixed | ||
| - Inline the custom javascript using ` ()` |
There was a problem hiding this comment.
The function name appears to be incomplete or corrupted. It should be wp_print_inline_script_tag() instead of just the backticks with a tab character.
Suggested change
| - Inline the custom javascript using ` ()` | |
| - Inline the custom javascript using `wp_print_inline_script_tag()` |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the plugin to version 1.1.6 and addresses how custom JavaScript is added to WordPress sites. The main improvements are switching to the recommended WordPress function for inlining JavaScript and moving the script output from the page header to the footer for better performance and compatibility.
JavaScript Output Improvements:
wp_print_inline_script_tag(), which is the WordPress-recommended approach for adding inline scripts.<head>(usingwp_head) to the footer (usingwp_footer), ensuring scripts are loaded at the optimal time.Version and Documentation Updates:
additional-javascript.php,package.json, and updated the stable tag inreadme.txt. [1] [2] [3]CHANGELOG.mdandreadme.txtto document these changes. [1] [2]