Skip to content

Add Blame command to WorkingCopyContextMenu #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

oikku
Copy link
Contributor

@oikku oikku commented Jul 7, 2025

No description provided.

@love-linger
Copy link
Collaborator

For File/Dir History, it is understandable to enable it in LOCAL CHANGES because they show all the commits in history that changes the selected file/dir exclude the current state of file (since it has not been committed). However, for Blame, it is not appropriate to place it here. The reasons are:

  • Blame shows who last modified each line of a file, along with the commit hash and timestamp for each change. But it can not include the changes in current worktree.
  • It will not work for untracked files, but it can work for deleted file in current worktree (not commited yet)

@love-linger love-linger self-assigned this Jul 8, 2025
@oikku
Copy link
Contributor Author

oikku commented Jul 8, 2025

With large project having 20 years of history and multiple editors I find myself using blame when editing file. You start making changes and at some point you encounter code you really don't understand why it is done how it is done and at that point you want to see the blame of original file before your changes to get better understanding of the situation. Now when blame is missing from local changes extra work has to be done to open that blame view.

Untracked files could be skipped just like directories and it could be shown to deleted files.

@love-linger love-linger merged commit 4ef3ed8 into sourcegit-scm:develop Jul 8, 2025
love-linger added a commit that referenced this pull request Jul 8, 2025
Signed-off-by: leo <longshuang@msn.cn>
love-linger added a commit that referenced this pull request Jul 8, 2025
Signed-off-by: leo <longshuang@msn.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants