Skip to content

sqlite 3.38.5 #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2022
Merged

sqlite 3.38.5 #513

merged 2 commits into from
Jun 1, 2022

Conversation

jonasb
Copy link
Contributor

@jonasb jonasb commented May 31, 2022

  • Upgrade sqlite to 3.38.5
  • Upgrade Emscripten to 3.0.0

Seems to work well for me. All tests except test_worker passed, but that test didn't work for me before the upgrade.

Had some issues with compilation where it would fail (signal -9) the first time. Probably something wrong with the VS Code devcontainer setup. Build went through on second attempt.

@lovasoa
Copy link
Member

lovasoa commented Jun 1, 2022

If we update emscripten, then we should do it both in the dev container and in CI ( in .github/workflows)

@lovasoa
Copy link
Member

lovasoa commented Jun 1, 2022

Sorry, the ci was standardized to use the dev container already

@lovasoa lovasoa merged commit 3f054c2 into sql-js:master Jun 1, 2022
@jonasb
Copy link
Contributor Author

jonasb commented Jun 1, 2022

@lovasoa Thanks! 🎉

@lovasoa
Copy link
Member

lovasoa commented Jun 1, 2022

Thank you!

@ghost
Copy link

ghost commented Jun 30, 2022

3.39.0 ?

ojamin pushed a commit to ojamin/sql.js-absurd-sql that referenced this pull request May 7, 2025
* Upgrade to Emscripten 3.0.0

* Upgrade to sqlite 3.38.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants