-
Notifications
You must be signed in to change notification settings - Fork 102
docs: rule suppressions #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
# Rule Suppressions | ||
|
||
You can suppress specific diagnostics or rules in your code using suppression comments. This is useful when you want to ignore a particular rule for an entire file, a line or a block of code. | ||
|
||
## How to Suppress a Rule | ||
|
||
To suppress a rule, add a comment above the line causing the diagnostic with the following format: | ||
|
||
```sql | ||
-- pgt-ignore lint/safety/banDropTable | ||
drop table users; | ||
``` | ||
|
||
You can suppress single rules, groups of rules, or entire categories. The format of the rule to suppress is: | ||
|
||
`category(/group(/specific-rule))` | ||
|
||
Where group and specific rule are optional. | ||
|
||
So, to suppress the `lint/safety/banDropTable` diagnostic, all of these would work: | ||
|
||
```sql | ||
-- pgt-ignore lint | ||
-- pgt-ignore lint/safety | ||
-- pgt-ignore lint/safety/banDropTable | ||
``` | ||
|
||
You can also add an explanation to the suppression by adding a `:` and the explanation text: | ||
|
||
```sql | ||
-- pgt-ignore lint/safety/banDropTable: My startup never had any users. | ||
drop table users; | ||
``` | ||
|
||
### Suppressing Rules for Block of Code | ||
|
||
You can suppress rules for blocks of code. | ||
|
||
```sql | ||
create table users ( | ||
-- ... | ||
); | ||
|
||
-- pgt-ignore-start typecheck: The `users` table will be created with this migration. | ||
alter table users drop constraint users_pkey; | ||
|
||
alter table users add primary key (user_id); | ||
-- pgt-ignore-end typecheck | ||
``` | ||
|
||
Every `pgt-ignore-start` needs a `pgt-ignore-end` suppression comment, and the suppressed rules must match exactly. | ||
|
||
This _won't_ work, because the start tag suppresses a different diagnostic: | ||
|
||
```sql | ||
-- pgt-ignore-start lint/safety/banDropColumn | ||
-- pgt-ignore-end lint/safety | ||
``` | ||
|
||
Nesting is allowed, so this works fine: | ||
|
||
```sql | ||
-- pgt-ignore-start typecheck: outer | ||
-- pgt-ignore-start lint/safety: inner | ||
-- pgt-ignore-end lint/safety: inner | ||
-- pgt-ignore-end typecheck: outer | ||
``` | ||
|
||
### Suppressing Rules for Entire Files | ||
|
||
Instead of repeating the same suppression on multiple lines, you can suppress for an entire file. | ||
|
||
```sql | ||
-- pgt-ignore-all lint/safety/banDropTable | ||
|
||
drop table tasks; | ||
drop table projects; | ||
drop table users; | ||
``` | ||
|
||
## Suppressing Multiple Rules | ||
|
||
You can suppress multiple rules by adding multiple suppression comments above a statement: | ||
|
||
```sql | ||
-- pgt-ignore lint/safety/banDropColumn | ||
-- pgt-ignore typecheck | ||
alter table tasks drop column created_at; | ||
``` | ||
|
||
## Notes | ||
|
||
- Trying to suppress diagnostics that have already been disabled in your [configuration file](/#configuration) will show a warning. | ||
- Trying to suppress diagnostics that don't haven't been raised will also show a warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.