Clean up block device detection logic #3175
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #3174 (comment):
In the end I elected to not remove the
mknod
code as I figured that there may be a legitimate case where it's needed. However, in this PR I edit it to only be called if the partition fs nodes are not found after repeated kernel refreshing, and, after it runs, the device partitions are re-checked before continuing. If this succeeds then the process continues tomkexfatfs
, and, if not, the user is advised to try re-inserting the USB or retrying with other ports/hardware.I hope this PR is okay? It's my first to the project and I hope it's helpful in some way.
Closes #3174 and #3256