| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Make simplebrowser deployable.
Pick-to: 6.9
Change-Id: I4717c30d1048c0c76306a71c657499b997a146c4
Reviewed-by: Moss Heim <moss.heim@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Remove an unused member, dynamically populate the policy combo box so
its items and data stay synced, fix a documentation typo, and simplify a
few expressions.
Pick-to: 6.8 6.9
Change-Id: I37997fbbeca51ed4c71c83a86d989917ce92b3df
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
| |
This conflicts with a target named server in qtbase benchmarks. Give the
targets more unique names.
Pick-to: 6.8 6.9
Change-Id: I52d71e37c976ada5bf48813ecaf200923b07aef6
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.9 6.8
Change-Id: I0e973f599218a719aa8cff0ce65c4d35cefe4b3f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Add *.pdf to open dialog filter.
Change-Id: Ifc70c1dc1356341bea78d46f775a2c517e041b15
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
All our other examples use 3.16, and cmake 3.30 now gives a deprecation
warning about this.
Pick-to: 6.8 6.9
Change-Id: If2aff723cedab0339ba506484b44bddd89858307
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
| |
Clang warns about these when compiling.
Pick-to: 6.8 6.9
Change-Id: Idf0daf9f4b7c71fefaddb4531d9ed164e90d118e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Also validate return value of QIODevice::open() and QBuffer::open()
calls.
Pick-to: 6.8 6.9
Change-Id: I71ea58f62cab5aafdd2b4eca217394dddf0033cd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Moss Heim <moss.heim@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a wrapper designed to handle profile construction.
The QWebEngineProfile class allows the modification of profile storage
properties, which is against chromium profile design. Changing storage
properties requires the recreation of storage and network context
leading to hacks, which in turn leads to bugs.
The QWebEngineProfileBuilder aims to prevent modification of storage
properties and set them at the profile creation time. The current change
introduces new APIs without deprecating the storage setters in the
QWebEngineProfile class. The final goal is to deprecate the storage
setters and constructor from QWebEngineProfile and use the
QWebEngineProfileBuilder to create profiles.
Task-number: QTBUG-66068
Change-Id: I3c2562c9e1445708f0dbdeae5783a8c7d38313af
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
REUSE.toml files are read by reuse to complement or override the
copyright and licensing information found in file.
The use of REUSE.toml files was introduced in REUSE version 3.1.0a1.
This reuse version is compatible with reuse specification
version 3.2 [1].
With this commit's files,
* The SPDX document generated by reuse spdx conforms to SPDX 2.3,
* The reuse lint command reports that the Qt project is reuse compliant.
In order to be reuse compliant all the licenses referenced in file
or within a REUSE.toml file must be present in the LICENSES
directory at the base of the module.
The missing licenses are added.
[1]: https://reuse.software/spec-3.2/
Task-number: QTBUG-124453
Task-number: QTBUG-125211
Pick-to: 6.8
Change-Id: Ic8c34b884bae1151f5d912f375bf87378e6e9a3d
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
| |
Fixes a couple of broken links, a broken list, and a missing \c tag.
Pick-to: 6.8
Change-Id: I57bd37aea88a3780b1897ab0223d7964e6399755
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following the rewrite of the permissions API, transient
(a.k.a non-persistent) permissions still passed through
the persistent store sometimes, but were filtered out when
using user-facing APIs. Unfortunately, thisstill presented some
edge cases in the AskEveryTime permission policy mode.
This change modifies the PermissionManagerQt class to store
a second set of permissions, and associate them with a
RenderFrameHost the way the Chromium API is designed to do
anyway. This way, a permission will be kept around for the
lifetime of a web page, and calling JavaScript APIs that
trigger checks for permission state will work properly
(e.g. navigator.mediaDevices.enumerateDevices).
The new store is regularly cleaned up to make sure expired
permissions are purged before they impact performance.
As a side effect, this change also introduces pre-granting
of non-persistent permissions, which was the biggest
omission in the permissions rewrite. In those cases,
the permissions will be temporarily stored inside the
persistent store, and moved to the transient one the next
time they're queried (and can thus be associated with
a RenderFrameHost).
This also fixes some extremely broken test cases that
relied on invalid web API.
Fixes: QTBUG-127951
Pick-to: 6.8
Change-Id: Ic084af7673ea0b255d98d94382e77323bb5e7ab0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
In updateWidget,receivedBytes / m_timeAdded.elapsed() * 1000 may divide
by zero,if m_timeAdded.elapsed() returns 0, it will cause the denominator
in the division to be zero, which will trigger a warning or error, to fix this,
check the m_timeAdded.elapsed() is zero, if it is, you can set a default
value () or just set bytesPerSecond to 0 to avoid dividing by zero.
Pick-to: 6.8 6.7
Change-Id: Id73b287d44241f97271308f85c64d4830b944948
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
m_progressBar->setValue(qRound(100 * receivedBytes / totalBytes));
There is a potential risk of de-zeroing here, since
receivedBytes / totalBytes will trigger a runtime
error if totalBytes is zero. In addition, if totalBytes
is always greater than or equal to 0, then checking for
totalBytes >= 0 is actually redundant, since the concern
should be that totalBytes is not zero. To ensure the robustness
of the code, a check that totalBytes is zero should be added
to prevent divide-by-zero errors. By ensuring that totalBytes
is greater than zero, this improvement not only avoids the
risk of de-zeroing, but also ensures that the percentage
calculation of the progress bar is meaningful. At the same
time, for cases where totalBytes is 0 or unknown, the progress
bar is displayed as 0% and the format is "unknown size".
This is a safer way to handle the situation and is more
in line with the needs of the actual application.
Pick-to: 6.8 6.7
Change-Id: I7537243e375f336f5c68ef1cc6ec8ade8fa16e5c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Use the macros \QC and \QD.
Change-Id: I58c6064916b2449a63b5389a9afe7b64f772e3c2
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
| |
Removes ambiguous conversion of string types.
Fixes: QTBUG-127544
Pick-to: 6.8
Change-Id: I53d444b641c4b5190c1e391d9df21ccd7076ef13
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example takes precedence over build system file type.
According to QUIP-18 [1], all examples file should be
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.8
Task-number: QTBUG-121787
Change-Id: Ifb33a2b284ef234648b50d2333e83f7015023405
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Reviewed-by: Kaloyan Chehlarski <kaloyan.chehlarski@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit contains fixes for the issues found during the API review
of the new permissions API. In particular:
- All new enums are now scoped
- Replaced isTransient with its opposite, isPersistent
- Renamed Feature to PermissionType
- Made origin() return a non-const QUrl
- Renamed PersistentPermissionsPolicy members to be more concise
- Fixed a couple of bugs in the implementation
- Updated documentation
Change-Id: Idf84e1c9ba3ae803ef4686e1caa7f3e6c198c87d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
Amends 8e22839aa0
Task-number: QTBUG-126403
Pick-to: 6.7 6.8
Change-Id: I1560e5af29d2e94657a83e98bb649729b4a67cd2
Reviewed-by: Lucie Gerard <lucie.gerard@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
We aim for using only valid SPDX expressions in LicenseId fields.
But SPDX does not contain a generic 'Public Domain' license, which
is why we were going for urn.dje licenses originally. Anyhow,
best practice is to use custom LicenseRef- licenses in this case.
Task-number: QTBUG-126403
Pick-to: 6.7 6.8
Change-Id: I1d050ae42603168c6a4c9d44eeb7fdd6767af060
Reviewed-by: Lucie Gerard <lucie.gerard@qt.io>
|
|
|
|
|
|
|
|
|
| |
Fix compiler warnings that are related to QWebEnginePermission.
Pick-to: 6.8
Change-Id: Icac1352e4934f73a205b85896b6f83171b759dd3
Reviewed-by: Kaloyan Chehlarski <kaloyan.chehlarski@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.8
Change-Id: I2c03c6d56d18f37e60b287c337c67718178fbb2b
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
| |
The example demonstrates how to properly use the new
QWebEnginePermission API to manage incoming and existing
website permissions.
Pick-to: 6.8
Change-Id: I21fd01879f7bd89fc2239fde38f5b6456f193578
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the addition of permission persistence, it's now important for us
to have an API for querying previously granted/denied permissions, so
that they can be revoked at a later point. This change does the bulk
of the work to get us there, by introducing a new type representing
a single permission for a given URL/Feature pair.
This type holds no information about the permission's state; it is
simply an accessor object which allows its user to query the current
status of the permission, grant/deny it, or reset it back to its
initial state (so, delete it from storage). This provides application
developers an easy way to store/modify lists of permissions without
having to define their own custom types. A subsequent change will expand
the API to provide a list of all permissions for a given profile.
The current API (in QWebEnginePage and QQuickWebEngineView) has been
marked as deprecated, but has not been disabled to ensure a smooth
transition for developers.
[ChangeLog][QtWebEngineCore][QWebEnginePage] Deprecated old
permissions API
[ChangeLog][QtWebEngineQuick][WebEngineView] Deprecated old
permissions API
[ChangeLog][QtWebEngineCore] Added new API for querying and modifying
website permissions.
[ChangeLog][QtWebEngineQuick] Added new API for querying and modifying
website permissions.
Pick-to: 6.8
Change-Id: I8661cdc26bbd6dcde6403d29cc083bcea1a49ccc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, all certificate errors are handled the same way, regardless
of whether they come from the main frame or from an outside resource.
On the user side, this means that all certificate errors for resources
trigger a pop-up claiming the page is unsafe. Other browsers do not
do this, and instead automatically reject bad certificates for
resources.
This change extends the QWebEngineCertificateError API to allow
querying for whether the error comes from the main frame, or from
a resource. This information is already supplied by Chromium, but we
previously just ignored it. With this, application developers may now
choose to auto-reject resource errors just as Chrome does.
The simple and quick nano browser examples have been updated to
reject certificate errors coming from a page resource.
Task-number: QTBUG-92009
Change-Id: Id38b21f569318d7a83332d4ba69cb27d14b53430
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously simplebrowser did not make use of the RequestClose webaction
to trigger the beforeunload JavaScript event. This meant that closing a
tab would not trigger this event or a confirmation dialog, but reloading
a tab would.
This commit hooks up the appropriate signal in the example code.
Fixes: QTBUG-124004
Change-Id: I0a4ce242b6c2f89583504841d817285610be0bd0
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The example runs a nested event loop while waiting for the printer
to return a document. During that event loop, a user was previously
free to click on any of the buttons in the print preview dialog,
whoich would mess up the internal state and cause a crash. This change
adds a filter to that event loop to exclude user input events, and
updates the docs to mention the reasoning behind this pattern.
Fixes: QTBUG-122916
Pick-to: 6.7
Change-Id: I4d3d336ffa9bd23e036772bd78f6f1e5870ab732
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example takes precedence over build system file type.
According to QUIP-18 [1], all examples file should be
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I558c6f409a480835d335101577ae633194b0559d
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.7
Change-Id: I1fe5fe8620055eec7c7fd4831459b0aa39864f97
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, permissions for clipboard access could only be managed
through the JavascriptCanAccessClipboard and JavascriptCanPaste
settings. This change allows copy/paste to be handled the same way
as notification and geolocation permissions.
If both JavascriptCanAccessClipboard and JavascriptCanPaste are
enabled, permissions will be granted unconditionally without a
feature request being made.
Fixes: QTBUG-77450
Change-Id: I383e27e244ced3d6b7988644e38d2307c6267f76
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
- added a method to set image animation policy in QWebEngineSettings
Fixes: QTBUG-86154
Change-Id: I8b3ab6067f9cff4219b0da90bb8601406cb98e24
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
- Modified WebAuthUXState as enum class
- Renamed QWebEngineWebAuthUXRequest as QWebEngineWebAuthUxRequest
- Renamed QWebEngineWebAuthPINRequest as QWebEngineWebAuthPinRequest
- Replaced all occurrence of UX and PIN with Ux and Pin respectively
Fixes: 6.7
Change-Id: Iaf0b4c93e0dfa3508a604f7d6562c4401ff800af
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
In cookiebrowser example, all new cookie widgets are added at position
0. Background color of the newly added widget is set based on the
color of last inserted cookie widget.
Fixes: QTBUG-120446
Pick-to: 6.7 6.6 6.5
Change-Id: I76fe3ae83b31489365396a2ebcd31d840b2fa857
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Also fixed the qrc file.
Fixes: QTBUG-119738
Pick-to: 6.6 6.7
Change-Id: I97e981260fff90e6f9ef3a1ea661d9cf47e6ee45
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-119732
Pick-to: 6.6 6.7
Change-Id: Ibfdc2989cea704a05fa5f6ed038c2b08498285e7
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.6 6.7
Fixes: QTBUG-119732
Change-Id: Ia034b8a1566cd2858ccfe1313d73b503b10d752b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][WebEngineCore] Add QWebEnginePage::desktopMediaRequested() signal
[ChangeLog][WebEngineQuick] Add QQuickWebEngineView::desktopMediaRequested() signal
Pick-to: 6.7
Fixes: QTBUG-112142
Task-number: QTBUG-70077
Change-Id: I4bfad88732b45fb68b77f7617440bcb50b248a11
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Multiline copyright entries are entered via string array.
Task-number: QTBUG-111873
Pick-to: 6.5 6.6
Change-Id: I1b90e5333505227db66bc25d3baba8311afda37d
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
| |
- Corrected the typo in the file system access window title.
Pick-to: 6.6
Change-Id: I9667726527e90477f6602e9ac8acf1a68742abe7
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We kept urls in examples to point to company website.
However this site is heavy to load and moreover it changes
overtime leaving example screenshots obsolete.
Introduce internal qt version web ui page which will
be default page for examples and which displays basic
information and can work offline.
For start show version info and command line options
for chrome://qt
Pick-to: 6.6
Change-Id: I0271ce6e7b152efe4942a6240b0c74ba382d5fcc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quick Nano Browser and Simple Browser need this to be able to use the
camera and microphone on macOS.
Also document the need for signing the applications in the examples
documentation.
Pick-to: 6.6
Task-number: QTBUG-114939
Change-Id: I7a260a7ec62138fec8f7b4d6c1f2009eee9004d6
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebEngine examples are generally added to the new 'Web Technologies'
category - only Nano Browser remains also in the 'Application Examples'
category.
The 2 Qt PDF examples are placed in the 'Graphics & Multimedia'
category. This is not ideal, but from the existing categories the
arguably best matching one.
Pick-to: 6.5 6.6
Task-number: QTBUG-115174
Change-Id: I3824272f62a4940f91041c8694fd2a06929863ed
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
| |
- Updated the application's path for code signing.
Change-Id: I8469d573ba5f952d02734bc75e33b34f0c6e4494
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
If no settings loaded, start recipe browser example
with no style sheets applied.
Fixes: QTBUG-114471
Pick-to: 6.6 6.5
Change-Id: Ibdcf0e5171dfa76925e9af95754f0583aedec9bd
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtPositioningHelper now uses the Qt Permissions API. Also fixup the
examples Simple Browser, Quick Nano Browser and Maps to use the right
key on macOS and sign the application as part of the build process
Moves the Geopermission auto tests to manual tests for webenginequick
and webenginewidgets on macOS.
Pick-to: 6.6
Fixes: QTBUG-114939
Change-Id: Id6771889f20c866d2fcdbb477dbbb7da30367043
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
- Implemented AuthenticatorRequestClientDelegateQt support to handle authenticator requests.
- Added FIDO user verification and resident credential support
Fixes: QTBUG-90938
Fixes: QTBUG-90941
Change-Id: I6367791e1e9e8aaac27c376408377f838832f426
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
There's already nanobrowser in Application Examples so this removes the
other webengine examples from that category.
Pick-to: 6.5.2 6.5 6.6
Change-Id: I1f6dc7be7cb0ad4b0ac8134eb438ac0a0db7a5d3
Reviewed-by: Tuukka Turunen <tuukka.turunen@qt.io>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
|
|
|
|
|
|
|
| |
Pick-to: 6.6 6.5 6.5.2
Change-Id: I795da5e37bd084e5c101aaed14fda5a9b3be4b92
Reviewed-by: Kimmo Leppälä <kimmo.leppala@qt.io>
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This manifest is required for User-Agent to report the
correct Windows versions.
Document Windows App Manifest in platform-notes and
mention it in the httpUserAgent documentation.
Pick-to: 6.6
Fixes: QTBUG-63021
Change-Id: Ie3896c50a0a912742e8d1a0dc20f3305b343d3f4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The '\meta category' command was used for tagging examples with a
specific category, used in Qt Creators Welcome mode.
As we want to also generate lists of examples belonging to a category
elsewhere in the documentation, replace the command with a macro that
expands to the original \meta command and also adds the example to
a group using the \ingroup command. This way, the category names can
be used as arguments to the \generatelist or \annotatedlist commands.
Pick-to: 6.5
Task-number: QTBUG-112731
Change-Id: If9519fd8994c64cf57dc4c9a9387d7be80493d80
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|