Skip to content

fix: There may be misalignment when extracting Excel spreadsheets using applications #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

shaohuzhang1
Copy link
Contributor

fix: There may be misalignment when extracting Excel spreadsheets using applications

Copy link

f2c-ci-robot bot commented Aug 5, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

f2c-ci-robot bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 3edc684 into v2 Aug 5, 2025
3 of 4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_ai_chat_table branch August 5, 2025 03:21
.execution-detail-panel {
width: var(--execution-detail-panel-width, 400px);
}
}
@media only screen and (max-width: 1000px) {
.chat-width {
max-width: 100% !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code includes several issues that need attention to ensure proper functionality:

  1. Missing closing tag: There's an unclosed <style> tag at the end of the document, which should be properly closed with </stlye>.
+</style>
  1. Potential issue with CSS variable precedence and fallbacks: The use of CSS variables and fallbacks is correct, but make sure these declarations are loaded after other styles in case there are conflicting rules.

  2. Incorrect usage of .pc__right class: The selector ".chat-pc__right" is not defined anywhere in your provided HTML, so it won't work as intended. If it's meant to have default styles, consider renaming the class or adding missing definitions.

  3. Suggestion for cleaner code structure: Consider organizing your CSS into separate files for better maintainability. Also, if you want to keep this within one file, ensure that all CSS variables are declared before they're used, and use a consistent naming convention for classes/styles.

Optimization Suggestions:

  1. Reduce inline styles where possible: Move repeated styles to global CSS or external stylesheets to avoid duplicating CSS across multiple elements.

Here's how you might fix some issues and implement optimizations:

@@ -577,7 +570,9 @@ function closeExecutionDetail() {

-.chat-width {
+*,
+:not(.no-style) {
   box-sizing: border-box;
 }

+.chat-pc__right {
   max-width: 80vw /* Adjusted to percentage */;
}

@media only screen and (max-width: 1000px) {
  .chat-width {
    max-width: 100% !important;
 }
}

Replace "Adjusted to percentage" with the appropriate value based on your layout's responsiveness needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant