Skip to content

fix: There may be misalignment when extracting Excel spreadsheets using applications #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix: There may be misalignment when extracting Excel spreadsheets using applications #3809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions ui/src/views/chat/pc/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,12 @@
</div>
<div
class="chat-pc__right chat-background"
:style="{ backgroundImage: `url(${applicationDetail?.chat_background})` }"
:style="{
backgroundImage: `url(${applicationDetail?.chat_background})`,
'--execution-detail-panel-width': rightPanelSize + 'px',
}"
>
<div style="flex: 1">
<div style="flex: 1; width: calc(100% - var(--execution-detail-panel-width))">
<div class="p-16-24 flex-between">
<h4 class="ellipsis-1" style="width: 66%">
{{ currentChatName }}
Expand Down Expand Up @@ -160,12 +163,7 @@
</AiChat>
</div>
</div>
<div
class="execution-detail-panel"
:style="`width: ${rightPanelSize}px`"
:resizable="false"
collapsible
>
<div class="execution-detail-panel" :resizable="false" collapsible>
<div class="p-16 flex-between border-b">
<h4 class="medium ellipsis" :title="rightPanelTitle">{{ rightPanelTitle }}</h4>

Expand Down Expand Up @@ -577,7 +575,13 @@ function closeExecutionDetail() {
max-width: 80%;
margin: 0 auto;
}

.chat-pc__right {
width: calc(100vw - 280px);
--execution-detail-panel-width: 400px;
.execution-detail-panel {
width: var(--execution-detail-panel-width, 400px);
}
}
@media only screen and (max-width: 1000px) {
.chat-width {
max-width: 100% !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code includes several issues that need attention to ensure proper functionality:

  1. Missing closing tag: There's an unclosed <style> tag at the end of the document, which should be properly closed with </stlye>.
+</style>

  1. Potential issue with CSS variable precedence and fallbacks: The use of CSS variables and fallbacks is correct, but make sure these declarations are loaded after other styles in case there are conflicting rules.

  2. Incorrect usage of .pc__right class: The selector ".chat-pc__right" is not defined anywhere in your provided HTML, so it won't work as intended. If it's meant to have default styles, consider renaming the class or adding missing definitions.

  3. Suggestion for cleaner code structure: Consider organizing your CSS into separate files for better maintainability. Also, if you want to keep this within one file, ensure that all CSS variables are declared before they're used, and use a consistent naming convention for classes/styles.

Optimization Suggestions:

  1. Reduce inline styles where possible: Move repeated styles to global CSS or external stylesheets to avoid duplicating CSS across multiple elements.

Here's how you might fix some issues and implement optimizations:

@@ -577,7 +570,9 @@ function closeExecutionDetail() {

-.chat-width {
+*,
+:not(.no-style) {
   box-sizing: border-box;
 }

+.chat-pc__right {
   max-width: 80vw /* Adjusted to percentage */;
}

@media only screen and (max-width: 1000px) {
  .chat-width {
    max-width: 100% !important;
 }
}

Replace "Adjusted to percentage" with the appropriate value based on your layout's responsiveness needs.

Expand Down
Loading