Skip to content

Store arrays offsets for boolean fields natively with synthetic source #125529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 25, 2025

Conversation

jordan-powers
Copy link
Contributor

@jordan-powers jordan-powers commented Mar 24, 2025

This patch builds on the work in #113757, #122999, and #124594 to natively store array offsets for boolean fields instead of falling back to ignored source when synthetic_source_keep: arrays.

@jordan-powers jordan-powers added >enhancement auto-backport Automatically create backport pull requests when merged test-full-bwc Trigger full BWC version matrix tests :StorageEngine/Mapping The storage related side of mappings v8.19.0 v9.1.0 labels Mar 24, 2025
@jordan-powers jordan-powers requested a review from martijnvg March 24, 2025 19:39
@jordan-powers jordan-powers self-assigned this Mar 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine
Copy link
Collaborator

Hi @jordan-powers, I've created a changelog YAML for you.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks Jordan!

@jordan-powers jordan-powers added auto-backport Automatically create backport pull requests when merged and removed auto-backport Automatically create backport pull requests when merged labels Mar 25, 2025
@jordan-powers jordan-powers merged commit af1f145 into elastic:main Mar 25, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125529

@jordan-powers
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

@jordan-powers jordan-powers deleted the offset-encoding-boolean branch March 25, 2025 16:15
elasticsearchmachine pushed a commit that referenced this pull request Mar 25, 2025
#125529) (#125596)

This patch builds on the work in #113757, #122999, and #124594 to natively
store array offsets for boolean fields instead of falling back to ignored
source when `synthetic_source_keep: arrays`.

(cherry picked from commit af1f145)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexVersions.java
#	server/src/main/java/org/elasticsearch/index/mapper/BooleanFieldMapper.java
jordan-powers added a commit that referenced this pull request Mar 26, 2025
… source (#125709)

This patch builds on the work in #113757, #122999, #124594, and #125529 to
natively store array offsets for unsigned long fields instead of falling
back to ignored source when synthetic_source_keep: arrays.
elasticsearchmachine pushed a commit that referenced this pull request Mar 27, 2025
… source (#125709) (#125746)

This patch builds on the work in #113757, #122999, #124594, and #125529 to
natively store array offsets for unsigned long fields instead of falling
back to ignored source when synthetic_source_keep: arrays.

(cherry picked from commit 689eaf2)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexVersions.java
#	x-pack/plugin/mapper-unsigned-long/src/main/java/org/elasticsearch/xpack/unsignedlong/UnsignedLongFieldMapper.java
jordan-powers added a commit that referenced this pull request Mar 28, 2025
…source (#125793)

This patch builds on the work in #113757, #122999, #124594, #125529, and 
#125709 to natively store array offsets for scaled float fields instead of
falling back to ignored source when synthetic_source_keep: arrays.
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
elastic#125529)

This patch builds on the work in elastic#113757, elastic#122999, and elastic#124594 to natively
store array offsets for boolean fields instead of falling back to ignored
source when `synthetic_source_keep: arrays`.
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
… source (elastic#125709)

This patch builds on the work in elastic#113757, elastic#122999, elastic#124594, and elastic#125529 to
natively store array offsets for unsigned long fields instead of falling
back to ignored source when synthetic_source_keep: arrays.
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
…source (elastic#125793)

This patch builds on the work in elastic#113757, elastic#122999, elastic#124594, elastic#125529, and 
elastic#125709 to natively store array offsets for scaled float fields instead of
falling back to ignored source when synthetic_source_keep: arrays.
elasticsearchmachine pushed a commit that referenced this pull request Mar 28, 2025
…source (#125793) (#125891)

This patch builds on the work in #113757, #122999, #124594, #125529, and
#125709 to natively store array offsets for scaled float fields instead of
falling back to ignored source when synthetic_source_keep: arrays.

(cherry picked from commit 71e74bd)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexVersions.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >enhancement :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine test-full-bwc Trigger full BWC version matrix tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants