Skip to content

[8.x] Store arrays offsets for boolean fields natively with synthetic source (#125529) #125596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jordan-powers
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

elastic#125529)

This patch builds on the work in elastic#113757, elastic#122999, and elastic#124594 to natively
store array offsets for boolean fields instead of falling back to ignored
source when `synthetic_source_keep: arrays`.

(cherry picked from commit af1f145)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexVersions.java
#	server/src/main/java/org/elasticsearch/index/mapper/BooleanFieldMapper.java
@jordan-powers jordan-powers self-assigned this Mar 25, 2025
@jordan-powers jordan-powers added :StorageEngine/Mapping The storage related side of mappings auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) and removed auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Mar 25, 2025
@jordan-powers
Copy link
Contributor Author

There's been a change in plans for the index versions on 8.x. Instead of a separate index version for each implementation, we'll just use the one version for all offset encoding implementations on 8.x (since there hasn't been a release). That's happening in #125610, so I'll wait for that to be merged before I merge this backport.

@jordan-powers jordan-powers added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 25, 2025
@elasticsearchmachine elasticsearchmachine merged commit 9314b2f into elastic:8.x Mar 25, 2025
15 checks passed
@jordan-powers jordan-powers deleted the backport/8.x/pr-125529 branch March 25, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :StorageEngine/Mapping The storage related side of mappings v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants