Migrate AWS Fargate metrics module to package #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
zmoog
changed the title
zmoog
force-pushed
the
zmoog/migrate-aws-fargate
branch
4 times, most recently
from
6b76523 to
064f19c
Compare
zmoog
commented
Apr 5, 2022
aspacca
reviewed
Apr 6, 2022
kaiyan-sheng
reviewed
Apr 7, 2022
zmoog
force-pushed
the
zmoog/migrate-aws-fargate
branch
from
1660402 to
a99b9a8
Compare
kaiyan-sheng
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
LGTM! One nit: could you compress the dashboard screenshot just in case it's too large. Reference pr: #2767
aspacca
approved these changes
Apr 12, 2022
Oh, you're right: it's quite big for a web resource, I see the other integration have far smaller sizes. I'm updating it! Thank you for bringing it up! |
# before (1.2M)
$ ls -l
-rw-r--r-- 1 zmoog staff 1291721 Apr 7 16:25 metricbeat-awsfargate-overview.png
$ pngquant --ext .png --force *.png
# after (400K)
$ ls -l
-rw-r--r-- 1 zmoog staff 407842 Apr 12 10:44 metricbeat-awsfargate-overview.png |
We decided the initial release will only include metrics
It is not required by the Elastic Agent
So we can use the very same sample event for validation
Added/fixed all the complaints from `elastic-package test` command.
This section title is a better fit for the content.
Right now it is aligned with the package release type
I overlooked these fields in the first iterations.
Effective and easy to apply using `pngquant --ext .png --force *.png`. Refs: elastic#2767
zmoog
force-pushed
the
zmoog/migrate-aws-fargate
branch
from
fb3ee05 to
1c2d060
Compare
4 tasks
zmoog
added
Integration:aws
andrewkroh
added
Integration:awsfargate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a brand new
awsfargatepackage with the migration of the awsfargate module from Metricbeat.As the origin module, this package supports the collection of the
task_statsmetrics from Amazon Elastic Container Service (Amazon ECS) clusters only.Metrics from the Amazon EKS clusters are not supported by this package yet.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Testing locally requires a special container from AWS.
To learn more, follow the step described at zmoog/til#7
Related issues
Screenshots
Integrations list:
Integration information:
Installation details: