Skip to content

Improve AWS Fargate package information #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Apr 14, 2022

What does this PR do?

This PR updates a couple of package information:

  • Improve the integration description to be more specific ("collects tasks metrics" vs. "Fargate integration"), so end users will know from the integrations list what it does.
  • Replace the integration screenshot with a new one, without any references to "Metricbeat".

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Integrations list:

CleanShot 2022-04-14 at 17 38 56@2x

Dashboard overview:

awsfargate-integration-overview

@zmoog zmoog changed the title Improve AWS Fargate integration description Improve AWS Fargate package information Apr 14, 2022
@zmoog zmoog self-assigned this Apr 14, 2022
@zmoog zmoog added the enhancement New feature or request label Apr 14, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-15T17:35:45.209+0000

  • Duration: 12 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Giving a less generic description in the integration tile is very important.
@zmoog zmoog force-pushed the zmoog/improve-package-info-on-aws-fargate branch from ba8e6c4 to 4731646 Compare April 14, 2022 15:40
@ravikesarwani
Copy link

Looks good from side.

zmoog added 2 commits April 15, 2022 19:32
The new one shows the actual dashboard from the integration
@zmoog zmoog requested a review from kaiyan-sheng April 15, 2022 17:38
@zmoog zmoog marked this pull request as ready for review April 15, 2022 17:38
@zmoog zmoog requested a review from a team as a code owner April 15, 2022 17:38
@zmoog zmoog merged commit 7547305 into elastic:main Apr 19, 2022
@zmoog zmoog deleted the zmoog/improve-package-info-on-aws-fargate branch April 19, 2022 18:43
@zmoog zmoog mentioned this pull request Apr 20, 2022
4 tasks
@zmoog zmoog added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants