-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rust: Support blanket implementations #20133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
paldepind
wants to merge
2
commits into
github:main
Choose a base branch
from
paldepind:rust/type-inference-blanket-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
983257d
to
2e98c24
Compare
2e98c24
to
f130198
Compare
This was referenced Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements method resolution for blanket implementations that satisfies the criteria that the type parameter for which the implementation targets has a trait bound.
For instance, this
impl
blockshould be handled as there is a trait bound
AsyncRead
on the type parameterR
.On the other hand, this
impl
blockis not handled since there is not trait bound for
T
.At a high level, the implementation works as follows:
foo.bar
check if there's a blanket implementation that has the methodbar
.foo
satisfies the trait bound.foo.bar
to the method from the blanket implementation.Todo
main
once Rust: Improve handling of where clauses in type inference and path resolution #20140 is merged and use the new predicate here.