Rust: Add type inference test cases resembling missing call targets in SQLx. #20160
+85
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Pull Request Overview
This PR adds test cases for type inference in Rust, specifically focusing on missing call targets for method calls on types that implement traits through blanket implementations. The test cases model patterns similar to those found in SQLx where methods are called on connection types that implement executor traits.
- Adds a new test module
execthat demonstrates trait method calls through blanket implementations - Updates the expected test output to include type inference results for the new test cases
- Includes the new test module in the main function call chain
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| main.rs | Adds new exec module with trait implementation test cases and includes it in main function |
| type-inference.expected | Updates expected test output with type inference results for the new test cases |
Yes! This should be covered by #20133. |
paldepind
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type inference test cases resembling the missing call targets in SQLx. I believe this is a common pattern.
@paldepind is this one of the issues on your radar and/or can you help me come up with what a fix might look like?