Skip to content

Add support for ActiveModel::Errors. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 11, 2017
Merged

Add support for ActiveModel::Errors. #22

merged 12 commits into from
Sep 11, 2017

Conversation

beauby
Copy link
Member

@beauby beauby commented May 18, 2017

No description provided.

houndci-bot
houndci-bot reviewed May 18, 2017
View reviewed changes
lib/jsonapi/rails/renderer.rb Outdated
@@ -16,9 +17,17 @@ def self.render(resources, options)
end
end

class ErrorRenderer
class ErrorsRenderer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.

lib/jsonapi/rails/renderer.rb Outdated
@@ -1,3 +1,4 @@
require 'jsonapi/rails/active_model_errors'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

lib/jsonapi/rails/active_model_errors.rb Outdated
end
end

class ActiveModelErrors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.

lib/jsonapi/rails/active_model_errors.rb Outdated
@@ -0,0 +1,39 @@
module JSONAPI
module Rails
class ActiveModelError
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.

lib/jsonapi/rails/active_model_errors.rb Outdated
@@ -0,0 +1,39 @@
module JSONAPI
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

@beauby beauby mentioned this pull request May 18, 2017
Closed
@mmun mmun mentioned this pull request Jun 24, 2017
Closed
@beauby beauby force-pushed the ar-validation-errors branch from 498c2b5 to 85b8249 Compare July 13, 2017 18:03
houndci-bot
houndci-bot reviewed Jul 13, 2017
View reviewed changes
lib/jsonapi/rails/renderer.rb Outdated
@@ -1,3 +1,4 @@
require 'jsonapi/rails/active_model_errors'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

lib/jsonapi/rails/active_model_errors.rb Outdated
@@ -0,0 +1,39 @@
module JSONAPI
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
lib/jsonapi/rails/railtie.rb Outdated
@@ -33,13 +33,13 @@ class Railtie < ::Rails::Railtie
RENDERERS[:jsonapi].render(resources, options).to_json
end

::ActionController::Renderers.add(:jsonapi_error) do |errors, options|
::ActionController::Renderers.add(:jsonapi_errors) do |errors, options|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]

@beauby beauby force-pushed the ar-validation-errors branch from f49e9a7 to 57afcdd Compare July 14, 2017 15:19
@beauby beauby force-pushed the ar-validation-errors branch from 57afcdd to ac98273 Compare July 25, 2017 11:24
houndci-bot
houndci-bot reviewed Jul 27, 2017
View reviewed changes
spec/render_jsonapi_spec.rb Outdated
@@ -0,0 +1,62 @@
require 'rails_helper'

describe ActionController::Base, "#render", type: :controller do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [49/25]
Prefer single-quoted strings when you don't need string interpolation or special symbols.

spec/render_jsonapi_errors_spec.rb Outdated
{
detail: 'Email must be a valid email',
title: 'Invalid email',
source: { pointer: "/data/attributes/email" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

spec/render_jsonapi_errors_spec.rb Outdated
{
detail: 'Name can\'t be blank',
title: 'Invalid name',
source: { pointer: "/data/attributes/name" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

spec/render_jsonapi_errors_spec.rb Outdated

context 'when rendering error hashes' do
controller do
def create
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [13/10]

spec/render_jsonapi_errors_spec.rb Outdated
end
end


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line detected.

spec/render_jsonapi_errors_spec.rb Outdated
},
{
"detail" => "Email must be a valid email",
"title" => "Invalid email",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

spec/render_jsonapi_errors_spec.rb Outdated
"source" => { "pointer"=>"/data/attributes/name" }
},
{
"detail" => "Email must be a valid email",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

spec/render_jsonapi_errors_spec.rb Outdated
"detail" => "Name can't be blank",
"title" => "Invalid name",
"source" => { "pointer"=>"/data/attributes/name" }
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the right brace the same as the start of the line where the left brace is.

spec/render_jsonapi_errors_spec.rb Outdated
"errors" => [{
"detail" => "Name can't be blank",
"title" => "Invalid name",
"source" => { "pointer"=>"/data/attributes/name" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Surrounding space missing for operator =>.

spec/render_jsonapi_errors_spec.rb Outdated
{
"errors" => [{
"detail" => "Name can't be blank",
"title" => "Invalid name",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@beauby beauby force-pushed the ar-validation-errors branch from 7078321 to e496357 Compare July 27, 2017 13:04
houndci-bot
houndci-bot reviewed Jul 27, 2017
View reviewed changes
spec/render_jsonapi_errors_spec.rb Outdated
let(:serialized_errors) do
{
'errors' => [{
'detail' => 'Name can\'t be blank',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

@beauby beauby force-pushed the ar-validation-errors branch 3 times, most recently from 276e7dc to a7e6841 Compare July 27, 2017 13:07
houndci-bot
houndci-bot reviewed Jul 27, 2017
View reviewed changes
lib/jsonapi/rails/active_model_errors.rb Outdated
end
end

class ActiveModelErrors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.

@beauby beauby force-pushed the ar-validation-errors branch from 0811702 to 0e13ab6 Compare July 31, 2017 11:02
houndci-bot
houndci-bot reviewed Jul 31, 2017
View reviewed changes
lib/jsonapi/rails/renderer.rb Outdated
options[:expose] =
controller.jsonapi_expose
.merge!(options[:expose] || {})
.merge!(_jsonapi_pointers: controller.jsonapi_pointers)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align .merge! with .jsonapi_expose on line 70.

lib/jsonapi/rails/renderer.rb Outdated
options.dup.tap do |options|
options[:expose] =
controller.jsonapi_expose
.merge!(options[:expose] || {})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align .merge! with .jsonapi_expose on line 70.

lib/jsonapi/rails/renderer.rb Outdated

# @api private
def default_options(options, controller)
options.dup.tap do |options|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadowing outer local variable - options.

lib/jsonapi/rails/renderer.rb Outdated
(options[:links] ||= {}).merge!(pagination_links)
end
options[:expose] = controller.jsonapi_expose
.merge!(options[:expose] || {})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align .merge! with .jsonapi_expose on line 27.

lib/jsonapi/rails/renderer.rb Outdated

# @api private
def default_options(options, controller, resources)
options.dup.tap do |options|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadowing outer local variable - options.

@beauby beauby force-pushed the ar-validation-errors branch from 0e13ab6 to d012897 Compare July 31, 2017 11:12
@beauby beauby force-pushed the ar-validation-errors branch 2 times, most recently from 49ce233 to cfcf79a Compare September 6, 2017 06:02
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 8, 2017
@beauby beauby force-pushed the ar-validation-errors branch from cfcf79a to 3fe4bad Compare September 9, 2017 16:50
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 9, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 9, 2017
@jsonapi-rb jsonapi-rb deleted a comment from houndci-bot Sep 9, 2017
@jsonapi-rb jsonapi-rb deleted a comment from NullVoxPopuli Sep 9, 2017
@beauby beauby force-pushed the ar-validation-errors branch from 3fe4bad to 9caf4a0 Compare September 10, 2017 20:17
@beauby beauby force-pushed the ar-validation-errors branch 3 times, most recently from 65a3db7 to f98b88b Compare September 11, 2017 00:20
@beauby beauby force-pushed the ar-validation-errors branch from f98b88b to 99a0509 Compare September 11, 2017 00:21
@beauby beauby force-pushed the ar-validation-errors branch from 5d22a0b to 86fde0c Compare September 11, 2017 07:30
@beauby beauby merged commit 0f31cda into master Sep 11, 2017
@beauby beauby deleted the ar-validation-errors branch September 11, 2017 07:37
@beauby beauby mentioned this pull request Sep 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beauby @houndci-bot