[WIP] Add basic support for ActiveModel::Errors. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 20, 2016
| JSONAPI::Serializable::ErrorRenderer.render(errors, options) | ||
| end | ||
|
|
||
| def self.build_active_model_errors(errors) |
There was a problem hiding this comment.
Method has too many lines. [11/10]
houndci-bot
reviewed
Nov 20, 2016
| end | ||
| end | ||
|
|
||
| module InstanceMethods |
There was a problem hiding this comment.
Missing top-level module documentation comment.
houndci-bot
reviewed
Nov 20, 2016
| module JSONAPI | ||
| module Rails | ||
| module ActiveModel | ||
| module Errors |
There was a problem hiding this comment.
Missing top-level module documentation comment.
houndci-bot
reviewed
Nov 20, 2016
| @@ -0,0 +1,25 @@ | |||
| module JSONAPI | |||
There was a problem hiding this comment.
Missing frozen string literal comment.
beauby
force-pushed
the
errors
branch
2 times, most recently
from
816201c to
9ef0567
Compare
houndci-bot
reviewed
Nov 20, 2016
| @app.call(env) | ||
| end | ||
|
|
||
| def deserialize!(request, body) |
There was a problem hiding this comment.
Method has too many lines. [11/10]
houndci-bot
reviewed
Nov 20, 2016
| end | ||
| end | ||
|
|
||
| module InstanceMethods |
There was a problem hiding this comment.
Missing top-level module documentation comment.
beauby
force-pushed
the
errors
branch
3 times, most recently
from
4c702c6 to
4f003a4
Compare
|
hi @beauby, will this be available on release? |
|
Hi @nathanpsouza – yes it is planned. There's a bit of work left but I have it on my radar. |
|
Closing in favor of #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.